addRole and assumeRole

delivery2/client/bin/rep_add_role

@@ -35,9 +35,6 @@ def addRole(args):
         logger.error("Need session file and role.")
         sys.exit(1)
     
-    #Validate role name
-    #TODO
-    
     # Check for session file
     if not os.path.isfile(BASE_DIR + args.session):
         logger.error("File '" + args.session + "' not found.")
@@ -47,7 +44,6 @@ def addRole(args):
     with open(BASE_DIR + args.session, 'r') as f:
         args.session = json.load(f)
 
-    # TODO:
     try:
         req = requests.post(f'http://{state['REP_ADDRESS']}/role/create/',
                             json=json.dumps({'role' : args.role}),
@@ -57,5 +53,8 @@ def addRole(args):
         logger.error("Failed to obtain response from server.")
         sys.exit(-1)
 
+    logger.info("Role added.")
+    sys.exit(0)
+
 if __name__ == '__main__':
     addRole(sys.argv[1:])

delivery2/client/bin/rep_add_subject

@@ -63,6 +63,7 @@ def addSubject(args):
         logger.error("Failed to obtain response from server.")
         sys.exit(-1)
 
+    logger.info('Subject added.')
     sys.exit(0)
 
 if __name__ == '__main__':

delivery2/client/bin/rep_assume_role

@@ -34,9 +34,6 @@ def assumeRole(args):
         logger.error("Need session file and username.")
         sys.exit(1)
 
-    #Validate role name
-    #TODO
-
     # Check for session file
     if not os.path.isfile(BASE_DIR + args.session):
         logger.error("File '" + args.session + "' not found.")
@@ -46,6 +43,21 @@ def assumeRole(args):
     with open(BASE_DIR + args.session, 'r') as f:
         args.session = json.load(f)
 
+    # Get roles in session
+    try:
+        req = requests.get(f'http://{state['REP_ADDRESS']}/role/session/list', headers={'Authorization': args.session['token']})
+        req.raise_for_status()
+    except requests.exceptions.RequestException as errex:
+        logger.error("Failed to obtain response from server.")
+        sys.exit(-1)
+
+    # Validate role name
+    roles = req.json()
+    if args.role not in roles.items():
+        logger.error("Role does not exist.")
+        sys.exit(1)
+
+
     # TODO:
     try:
         req = requests.post(f'http://{state['REP_ADDRESS']}/role/session/assume/' + args.role, headers={'Authorization': args.session['token']})
@@ -54,5 +66,8 @@ def assumeRole(args):
         logger.error("Failed to obtain response from server.")
         sys.exit(-1)
 
+    logger.info("You assumed the role %s.", args.role)
+    sys.exit(0)
+    
 if __name__ == '__main__':
     assumeRole(sys.argv[1:])